Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: to fetch booking with user as attendee in bookings list (user) filter #19376

Closed
wants to merge 9 commits into from
Closed

fix: to fetch booking with user as attendee in bookings list (user) filter #19376

wants to merge 9 commits into from

Conversation

vijayraghav-io
Copy link
Contributor

@vijayraghav-io vijayraghav-io commented Feb 19, 2025 •
edited
Loading

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • -N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@vercel Vercel
Copy link

vercel bot commented Feb 19, 2025

@vijayraghav-io is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Feb 19, 2025
@graphite-app graphite-app bot requested a review from a team February 19, 2025 12:11
@github-actions github-actions bot added bookings area: bookings, availability, timezones, double booking High priority Created by Linear-GitHub Sync organizations area: organizations, orgs 🐛 bug Something isn't working labels Feb 19, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Feb 19, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/19/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (02/19/25)

1 label was added to this PR based on Keith Williams's automation.

@vijayraghav-io
Copy link
Contributor Author

Creation of E2E tests in process

@vijayraghav-io
Copy link
Contributor Author

added E2E test

@eunjae-lee
Copy link
Contributor

Hey @vijayraghav-io Actually I have a big refactoring PR #19369 regarding this area, which conflicts. I've just applied your change over there, and I think your test case will be really helpful. I will also move it over there and see if my PR still works with your test case. Thanks for the work!

@eunjae-lee eunjae-lee closed this Feb 20, 2025
@vijayraghav-io
Copy link
Contributor Author

vijayraghav-io commented Feb 20, 2025 •
edited
Loading

Hey @vijayraghav-io Actually I have a big refactoring PR #19369 regarding this area, which conflicts. I've just applied your change over there, and I think your test case will be really helpful. I will also move it over there and see if my PR still works with your test case. Thanks for the work!

@eunjae-lee , Thanks! for letting me know.

saw my changes in your new PR.
So, the test case should still work fine.
I couldn't see the test yet, hopefully you are yet to add.
Or let me know after you merge, i can include only the test case here.

@eunjae-lee
Copy link
Contributor

Hey @vijayraghav-io Actually I have a big refactoring PR #19369 regarding this area, which conflicts. I've just applied your change over there, and I think your test case will be really helpful. I will also move it over there and see if my PR still works with your test case. Thanks for the work!

@eunjae-lee , Thanks! for letting me know.

saw my changes in your new PR. So, the test case should still work fine. I couldn't see the test yet, hopefully you are yet to add. Or let me know after you merge, i can include only the test case here.

I'm going to add it and test, and then push the commit by today. Thank you :)

eunjae-lee added a commit that referenced this pull request Feb 20, 2025
@eunjae-lee
add test from #19376
7e60153
@eunjae-lee eunjae-lee mentioned this pull request Feb 20, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eunjae-lee eunjae-lee Awaiting requested review from eunjae-lee

Assignees
No one assigned
Labels
bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working community Created by Linear-GitHub Sync High priority Created by Linear-GitHub Sync organizations area: organizations, orgs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CAL-5181] For org admins, we don't consider bookings as attendee for the user in bookings list
2 participants
@vijayraghav-io @eunjae-lee